chore: docusaurus build on Windows with GitHub actions #2100
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tweak for docusaurus build on v1 and v2
This comment has been minimized.
This comment has been minimized.
endiliey
changed the title
endiliey
changed the title
This comment has been minimized.
This comment has been minimized.
endiliey
added
the
pr: maintenance
|
Deploy preview for docusaurus-2 ready! Built with commit 8d24e31 |
|
Deploy preview for docusaurus-preview ready! Built with commit 8d24e31 |
|
@JoelMarcey is it okay to use GitHub actions ? Just making sure |
There was a problem hiding this comment.
We could look into moving all our builds from Circle CI to GitHub actions already. I tried that few months ago but they didn't have good support for non-root level npm projects. Glad that's fixed now.
Anyway here's Relay's Docusaurus GitHub workflow if you're interested in referring.
One thing to note is that I think GitHub actions also run on forks and then it might use up the contributors quota or not work well if they make a PR to Docusaurus 😂
|
Hmm relay’s one is on linux. We have an equivalent config on our circleci. I explicitly use gh actions since it supports windows build. I think its not a good idea yet to move to gh action since its still new and I notice slower build on gh actions than circleci. Im also more familiar with circleci and/or travis Maybe worth a revisit in future |
|
Its also hard for me to configure the move because we need to set the environment variable (such as crowdin api key). I also have limited access to this repo, example: “Setting” is not available for me Need this to set environment variable |
|
Mentioning that, I also dont have access to docusaurus crowdin api key 🤣 so I cant help on the move. The env is all hidden in circleci |
|
Uhh .. github mobile beta didn't squash and merge the PR 😢 |
|
@endiliey I think we can get you access to the api key. Would that help you immediately? |
|
@JoelMarcey I think we dont need to do anything for now. The thing is, GitHub action requires full access to the repo to setup environment variable (in particular the “setting”). But I think that can be very dangerous. Lets stick with circleci for now |
Motivation
Testing GitHub actions to build Windows for both v1 and v2 to prevent regression
all code is kinda self-made from reading https://help.github.com/en/actions/automating-your-workflow-with-github-actions
Seems to work well
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
TBD. CI should appear ??
Gonna release 2.0.0-alpha.39 soon for hotfix