Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(v1): showcase user Shrine #2128

Merged
merged 1 commit into from
Dec 16, 2019
Merged

docs(v1): showcase user Shrine #2128

merged 1 commit into from
Dec 16, 2019

Conversation

janko
Copy link
Contributor

@janko janko commented Dec 15, 2019

This adds Shrine to the list of Docusaurus users.

@facebook-github-bot
Copy link
Contributor

Hi janko! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit fc8cf6b

https://deploy-preview-2128--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit fc8cf6b

https://deploy-preview-2128--docusaurus-preview.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 15, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@yangshun yangshun changed the title Add Shrine to list of users docs(v1): showcase user Shrine Dec 16, 2019
yangshun
yangshun approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! ❤️

@yangshun yangshun merged commit ee00ecf into facebook:master Dec 16, 2019
@yangshun yangshun added the pr: documentation This PR works on the website or other text documents in the repo. label Dec 16, 2019
@janko janko deleted the add-shrine-user branch December 16, 2019 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun yangshun approved these changes

@endiliey endiliey Awaiting requested review from endiliey

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@janko @facebook-github-bot @docusaurus-bot @yangshun