Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention posthog-docusaurus plugin #2957

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

mariusandra
Copy link
Contributor

Motivation

I'm using PostHog to track my site's traffic. I need to send a $pageview event each time the URL changes. For this I need to hook into docusaurus - just adding posthog's JS snippet in the footer won't cut it.

Have you read the Contributing Guidelines on pull requests?

Yes! I even signed the CLA.

Test Plan

No code change, just added a link to the docs.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 18, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit bfe8407

https://deploy-preview-2957--docusaurus-2.netlify.app

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yangshun yangshun changed the title docs: Add PostHog Docusaurus v2 integration docs: mention posthog-docusaurus plugin Jun 18, 2020
@yangshun yangshun merged commit 162870d into facebook:master Jun 18, 2020
@yangshun
Copy link
Contributor

Btw a more common convention is to use docusaurus-posthog as the plugin name to indicate that it's a Docusaurus plugin.

@mariusandra mariusandra deleted the patch-2 branch June 18, 2020 11:38
@mariusandra
Copy link
Contributor Author

Hi @yangshun , thank you for the merge!

I had trouble choosing the name. In PostHog we have a lot of different integrations that are called posthog-*, so I followed that pattern.

I can still change it if it makes things better over here...

@yangshun
Copy link
Contributor

It's not a big deal, we don't have any restrictions that plugins must with docusaurus so it's all good :)

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jun 18, 2020
@mariusandra
Copy link
Contributor Author

Great, thanks again! :)

@slorber slorber mentioned this pull request May 23, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants