Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(v2): publish doc update after alpha.58 release #2960

Merged
merged 4 commits into from
Jun 19, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jun 18, 2020

publish doc update after alpha.58 release

cc @yangshun

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jun 18, 2020
@slorber slorber requested a review from yangshun June 18, 2020 13:51
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 18, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit c2d5f0a

https://deploy-preview-2960--docusaurus-2.netlify.app

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jun 18, 2020

Deploy preview for docusaurus-2 ready!

Built with commit aaab5b8

https://deploy-preview-2960--docusaurus-2.netlify.app

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Left a comment for your consideration

@@ -99,13 +144,24 @@ npm access ls-packages
</pre>
</details>

If all accesses are available, build all the necessary packages with `yarn tsc`, and then you can run the command to release a new version:
It can happen that some accesses not granted, as an admin might add you to the @docusaurus NPM organisation, but you don't have access to the packages that are not in that organisation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to shift this portion higher up to the "Check publish rights". Feels more related there.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I thought initially, but I think these rights might not apply for the v1 release process so I let them here

@yangshun yangshun merged commit 9301d0c into master Jun 19, 2020
@yangshun yangshun deleted the slorber/publish-doc-update branch June 19, 2020 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants