feat(v2): add option validation for remaining official plugins #2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teikjun
changed the title
|
Deploy preview for docusaurus-2 ready! Built with commit d89d118 |
teikjun
changed the title
slorber
reviewed
Jun 22, 2020
packages/docusaurus-plugin-content-docs/src/__tests__/pluginOptionSchema.test.ts
Show resolved
Hide resolved
|
Hey, is this ready to review/merge? The other pr has been merged: #2943 |
|
It is almost ready, we need to rebase it and make some minor changes |
|
Ready for review now :D |
|
there's a conflict :p |
|
conflict resolved! :) |
|
great job, let's merge this 👍 |
slorber
added
pr: maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR provides option validation for the remaining official plugins.
This is a follow-up PR to #2943. #2943 generalizes option validation for plugins and themes. This PR uses the same pattern to validate and normalize options for the remaining official plugins.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tests have been added for the respective plugins.
Related PRs
This PR should be merged after #2943. I will pull the changes after #2943 is merged to resolve any merge conflicts first. (Edit: done)