Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Fix typo in markdown-features #2973

Merged
merged 2 commits into from Jun 25, 2020
Merged

Conversation

ehsanjso
Copy link
Contributor

The code needed to be in npm syntax in order to work with npm2yarn

Motivation

(Write your motivation here.)

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

The code needed to be in npm syntax in order to work with npm2yarn
@ehsanjso ehsanjso requested a review from yangshun as a code owner June 20, 2020 12:39
@facebook-github-bot
Copy link
Contributor

Hi @ehsanjso!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jun 20, 2020

Deploy preview for docusaurus-2 ready!

Built with commit bb0adf2

https://deploy-preview-2973--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 20, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the changes in website/docs

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jun 24, 2020
@slorber slorber merged commit 8304e82 into facebook:master Jun 25, 2020
@slorber slorber changed the title Fix typo in markdown-features docs(v2): Fix typo in markdown-features Jun 25, 2020
@slorber
Copy link
Collaborator

slorber commented Jun 25, 2020

backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants