feat(v2): prompt user when default port is in use #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit dbf356c |
slorber
reviewed
Jun 29, 2020
| } | ||
|
|
||
| // Gets package name in a directory | ||
| async function getPackageNameInDirectory( |
There was a problem hiding this comment.
Are you saying to remove the export default function getProcessForPort ? I am using the function in another file.
slorber
approved these changes
Jun 29, 2020
|
@yangshun I guess it's not a problem to copy facebook code from one project to another right? This is heavily inspired from current CRA code: https://github.com/facebook/create-react-app/blob/f5c3bdb65480f93b2d4a4c2f3214fc50753de434/packages/react-dev-utils/WebpackDevServerUtils.js#L448 |
slorber
requested changes
Jun 29, 2020
slorber
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR implements what was proposed in #3005.
When a user already has a process running on the default docusaurus port, docusaurus finds the next open port and runs the client on it. Based on a simular implementation in create-react-app, this feature warns the user if something is already running on the default port, and asks them if they want to run the client on a different port.
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Run a program on port 3000 (I ran create-react-app)
yarn startWhen you try to run
yarn startwith another app already running on the Docusaurus default port:When you select "Yes":
When you select "No":
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)