Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): showcase Eta #3022

Merged
merged 1 commit into from
Jul 5, 2020
Merged

docs(v2): showcase Eta #3022

merged 1 commit into from
Jul 5, 2020

Conversation

nebrelbug
Copy link
Contributor

Motivation

I've loved using Docusaurus 2 to create the Eta docs, and would love to add Eta to the showcase.

Have you read the Contributing Guidelines on pull requests?

Yep!

Test Plan

Unnecessary

Related PRs

None

@nebrelbug nebrelbug requested a review from yangshun as a code owner July 5, 2020 02:22
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 5, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 0dafb79

https://deploy-preview-3022--docusaurus-2.netlify.app

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Great example of mutual benefit between libraries :)

@yangshun yangshun merged commit 46f794b into facebook:master Jul 5, 2020
@nebrelbug
Copy link
Contributor Author

@yangshun yes! Thank you too!

FocalChord pushed a commit to MLH-Fellowship/docusaurus that referenced this pull request Jul 7, 2020
Drewbi added a commit to MLH-Fellowship/docusaurus that referenced this pull request Jul 7, 2020
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants