Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): add useBaseUrlUtils() hook #3033

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 8, 2020

Motivation

Sometimes you need to add the baseUrl to a list of urls, and useBaseUrl() is not good for that

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

tests

Related PRs

See comments to support for baseUrl in Algolia DocSearch pr here: #2815

@slorber slorber requested a review from yangshun as a code owner July 8, 2020 14:36
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 8, 2020
@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Jul 8, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jul 8, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 8ecacc2

https://deploy-preview-3033--docusaurus-2.netlify.app

@slorber slorber merged commit a8b2e59 into master Jul 8, 2020
@yangshun yangshun deleted the slorber/useBaseUrlUtils branch July 26, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants