Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): netlify.toml shouldn't affect v1 site deployment config #3099

Merged
merged 4 commits into from
Jul 23, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 23, 2020

Motivation

Having netlify.toml at the root of the site messes up with the netlify v1 deploy preview setup (that now deploy v2...).

Nesting netlify.toml in /website should scope it better to v2 site only

@slorber slorber requested a review from yangshun as a code owner July 23, 2020 09:18
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 23, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jul 23, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 622ed1b

https://deploy-preview-3099--docusaurus-2.netlify.app

@slorber slorber merged commit 336c3e5 into master Jul 23, 2020
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jul 23, 2020
@yangshun yangshun deleted the slorber/fix-netlify-v1 branch July 26, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants