Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): add docusaurus script for npm users #3105

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 23, 2020

Motivation

NPM users should be able to run commands such as npm run docusaurus docs:version 1.1.0, but it fails by default while it works in yarn

#3100 (comment)

@slorber slorber requested a review from yangshun as a code owner July 23, 2020 16:28
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 23, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit ceab412

https://deploy-preview-3105--docusaurus-2.netlify.app

@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Jul 23, 2020
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change!

@yangshun yangshun merged commit 2c5675c into master Jul 23, 2020
@yangshun yangshun deleted the slorber/add-docusaurus-script branch July 23, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants