Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): baseUrl is wrongly appended to anchor links #3112

Merged
merged 2 commits into from
Jul 24, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 24, 2020

Motivation

It never makes sense to add a base url to a local anchor url like #site-configuration

fixes #3110

@slorber slorber requested a review from yangshun as a code owner July 24, 2020 10:35
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 24, 2020
@yangshun yangshun changed the title fix(v2): baseurl is wrongly appended to anchor links fix(v2): baseUrl is wrongly appended to anchor links Jul 24, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 23d5245

https://deploy-preview-3112--docusaurus-2.netlify.app

@yangshun yangshun merged commit f926178 into master Jul 24, 2020
@yangshun yangshun deleted the slorber/fix-anchor-links-baseurl branch July 24, 2020 10:40
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect section link behavior
4 participants