New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated OSS Logo to WebP #3187
Updated OSS Logo to WebP #3187
Conversation
Deploy preview for docusaurus-2 ready! Built with commit 0a2d21c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks but you didn't change the file extension in the footer, how can it have improved?
Hey, thanks for pointing this out. I seemed to have missed the last commit in my local. Apologies. Pushed the commit to replace the png with webp in the footer. |
How does this work for browsers not supporting webp?
Le sam. 1 août 2020 à 17:05, Shuvam Manna <notifications@github.com> a
écrit :
… Thanks but you didn't change the file extension in the footer, how can it
have improved?
Hey, thanks for pointing this out. I seemed to have missed the last commit
in my local. Apologies. Pushed the commit to replace the png with webp in
the footer.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3187 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFW6PT5TSTMQK7Q5X72WG3R6QVMXANCNFSM4PRZEO2Q>
.
|
Hi and thanks for this PR https://www.keycdn.com/support/webp-browser-support#webp-browser-support According to what I see, WebP can't be adopted as is because WebP is only supported by 80% of browsers If we want to use webp we need to fallback to regular images for browsers not supporting webp. https://css-tricks.com/using-webp-images/
Worth exploring, loading=lazy on images I think we could apply this lazy loading on images of the footer for all D2 sites, directly in the theme btw |
thanks, closing for now, but willing to reopen if a better solution is provided |
Motivation
The Lighthouse Performance of Docusaurus was significantly lagging at 73. Shifting from PNG to WebP led to a gain of 6.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
NA
Related PRs
#NA