Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-loadable-ssr-addon #3206

Closed
wants to merge 3 commits into from
Closed

Update react-loadable-ssr-addon #3206

wants to merge 3 commits into from

Conversation

RDIL
Copy link
Contributor

@RDIL RDIL commented Aug 4, 2020

Signed-off-by: Reece Dunham me@rdil.rocks

Motivation

Fixes the project on Yarn v2 (hopefully)

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

No significant changes

Related PRs

Fixes #3003

@RDIL RDIL requested a review from yangshun as a code owner August 4, 2020 11:25
@RDIL
Copy link
Contributor Author

RDIL commented Aug 4, 2020

cc @slorber

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 4, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Aug 4, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 36a72cc

https://deploy-preview-3206--docusaurus-2.netlify.app

Signed-off-by: Reece Dunham <me@rdil.rocks>
@slorber
Copy link
Collaborator

slorber commented Aug 5, 2020

weird the CI is stuck and I can't merge :D

Can you do an empty commit or something to trigger the CI again?

Unfortunately, you didn't give me perms to edit your PR so I can't trigger it myself :)

@RDIL
Copy link
Contributor Author

RDIL commented Aug 5, 2020

@slorber most likely because you aren’t a member of the organization it was forked to. I can send an invite if you want.

@slorber
Copy link
Collaborator

slorber commented Aug 5, 2020

@RDIL I'm a maintainer of this project, normally there's a checkbox on the PR to grant maintainers of the upstream repo write access, it's simpler than inviting me :)

image

@slorber
Copy link
Collaborator

slorber commented Aug 5, 2020

@RDIL can you open a brand new PR plz?

For some reason the CI does not even start, this is weird, never happened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project broken on Yarn v2
4 participants