Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v1): fresh install failing due to <> syntax #3213

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Aug 5, 2020

Motivation

Fix #3199

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 77b6f05

https://deploy-preview-3213--docusaurus-2.netlify.app

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this only surface now?

@slorber
Copy link
Collaborator Author

slorber commented Aug 5, 2020

because the last release was December 2019 🤪 and we don't have a CI check to ensure that the v1 init+start/build works fine

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Aug 5, 2020
@slorber slorber merged commit 83d160f into master Aug 5, 2020
@yangshun yangshun deleted the slorber/v1-jsx-parsing-bug branch August 5, 2020 14:19
@yangshun
Copy link
Contributor

yangshun commented Aug 5, 2020

Oh I see. For a moment I thought nobody was able to install v1 since Dec 2019 😅

Thanks for fixing this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fresh install will not start... Syntax Error
4 participants