Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(v2): swizzle minor improvements #3225

Merged
merged 3 commits into from
Aug 6, 2020
Merged

fix(v2): swizzle minor improvements #3225

merged 3 commits into from
Aug 6, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Aug 6, 2020

Motivation

  • Docs should allow swizzling with --typescript
  • Improved swizzle suggestion messages

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Manual cli testing

Related PRs

#3021

@slorber slorber requested a review from yangshun as a code owner August 6, 2020 12:38
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Aug 6, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 6, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit ad0b9ab

https://deploy-preview-3225--docusaurus-2.netlify.app

@slorber slorber merged commit 0079f0e into master Aug 6, 2020
@yangshun yangshun deleted the slorber/swizzle-enhancements branch August 26, 2020 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun Awaiting requested review from yangshun

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@slorber @docusaurus-bot @facebook-github-bot