feat(v2): debug pages + debug layout + ability to debug content #3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add multiple debug pages + debug layout - ability to debug plugin contentLoaded data
|
Deploy preview for docusaurus-2 failed. Built with commit d9eed7c https://app.netlify.com/sites/docusaurus-2/deploys/5f2c4f8ebf08920007512fd2 |
|
Deploy preview for docusaurus-2 ready! Built with commit f705977 |
This was referenced Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need some basic infrastructure, because displaying all debug data on the same page is not very sustainable.
Also, it's painful to work on the docs plugin as the contentLoaded data is complex and not intuitive to handle.
This data only in memory and not easy to debug.
I've enhanced the code so that the debug plugin can display such contentLoaded data.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview + Dogfooding
Note, I've forced the debug plugin on Docusaurus v2 website, so it can be seen here:
https://deploy-preview-3229--docusaurus-2.netlify.app/build/__docusaurus/debug
cc @SamChou19815, going to merge this tomorrow, as I need to refactor a bit the docs plugin contentLoaded I'll need this :)
MLH can probably try to make each page more beautiful, this PR is mostly the initial infra