fix(v2): modify validation schema and tests for rehype/remark + remove duplicate dependency #3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit c664d34 |
teikjun
commented
Aug 9, 2020
Comment on lines
14
to
21
| const MarkdownPluginsSchema = Joi.array() | ||
| .items( | ||
| Joi.array() | ||
| // TODO, this allows [config,fn] too? | ||
| .items(Joi.function().required(), Joi.object().required()) | ||
| .length(2), | ||
| .ordered(Joi.function().required(), Joi.object().required()), | ||
| Joi.function(), | ||
| Joi.object(), | ||
| ) | ||
| .default([]); |
There was a problem hiding this comment.
This completes the TODO for validating 'babel style' input and fixes the validation issue
There was a problem hiding this comment.
ordered is really cool
There was a problem hiding this comment.
yes, looked for that but couldn't find it. Joi doc is a pain :D
| @@ -107,8 +107,7 @@ | |||
| "webpack-bundle-analyzer": "^3.6.1", | |||
| "webpack-dev-server": "^3.11.0", | |||
| "webpack-merge": "^4.2.2", | |||
| "webpackbar": "^4.0.0", | |||
| "@docusaurus/utils-validation": "^2.0.0-alpha.61" | |||
There was a problem hiding this comment.
This is a duplicate dependency, the other one is on line 50
| expect(value).toEqual(DEFAULT_OPTIONS); | ||
| expect(error).toBe(undefined); |
There was a problem hiding this comment.
It is possible for value to match when there is an error, so it is safer to include this
|
LGTM thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR makes some changes related to validation:
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Automated tests