Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): fix migration command #3249

Merged
merged 1 commit into from
Aug 11, 2020
Merged

docs(v2): fix migration command #3249

merged 1 commit into from
Aug 11, 2020

Conversation

BogdanDor
Copy link
Contributor

Motivation

Fix incorrect command.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Go to https://v2.docusaurus.io/docs/migrating-from-v1-to-v2/#migration-command.
This section contains incorrect command.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 9, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit e970050

https://deploy-preview-3249--docusaurus-2.netlify.app

@teikjun
Copy link
Contributor

teikjun commented Aug 9, 2020

@BogdanDor thanks for fixing it! I've made the same changes for the earlier versions in PR #3251

@slorber
Copy link
Collaborator

slorber commented Aug 11, 2020

Thanks, but not needed anymore :)

@slorber slorber closed this Aug 11, 2020
@teikjun
Copy link
Contributor

teikjun commented Aug 11, 2020

@slorber I think this PR is still needed. I assumed that this PR would be merged, so I did not make the same changes for the latest docs in #3251. Sorry for the confusion 😅

@slorber
Copy link
Collaborator

slorber commented Aug 11, 2020

ah :) ok

@slorber slorber reopened this Aug 11, 2020
@slorber slorber changed the title docs: fix migration command docs(v2): fix migration command Aug 11, 2020
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Aug 11, 2020
@slorber slorber merged commit b75a715 into facebook:master Aug 11, 2020
@BogdanDor BogdanDor deleted the patch-1 branch August 27, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants