Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): allow swizzling of component even if case doesn't match #3281

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

anshulrgoyal
Copy link
Contributor

Motivation

Fixes #3148.

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

image

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 13, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Aug 13, 2020

Deploy preview for docusaurus-2 ready!

Built with commit e029192

https://deploy-preview-3281--docusaurus-2.netlify.app

@anshulrgoyal anshulrgoyal changed the title fix(v2): add support for case insensitivity for components fix(v2): allow swizzling of component even if case doesn't match Aug 13, 2020
@slorber slorber merged commit a4cc6b6 into facebook:master Aug 14, 2020
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Aug 14, 2020
@slorber
Copy link
Collaborator

slorber commented Aug 14, 2020

Thanks

@anshulrgoyal the swizzle.ts file starts to become bigger and bigger, and not so easy to understand. What about refactoring it a bit in smalller pure functions and adding some tests? As there's currently no test, it does not incite to add some when we touch this code, but all this should rather be tested ;p

@anshulrgoyal
Copy link
Contributor Author

Thanks

@anshulrgoyal the swizzle.ts file starts to become bigger and bigger, and not so easy to understand. What about refactoring it a bit in smalller pure functions and adding some tests? As there's currently no test, it does not incite to add some when we touch this code, but all this should rather be tested ;p

Yeah, I think same.

@slorber
Copy link
Collaborator

slorber commented Aug 14, 2020

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be resilient to Swizzle case typos
4 participants