Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): showcase SpotifyAPI-NET #3307

Merged
merged 1 commit into from
Aug 19, 2020
Merged

docs(v2): showcase SpotifyAPI-NET #3307

merged 1 commit into from
Aug 19, 2020

Conversation

JohnnyCrazy
Copy link
Contributor

Motivation

Hi 👋

I needed a good documentation solution for my open-source library, SpotifyAPI-NET. Docusaurus V2 was a joy to work with and even though it's still in alpha, I didn't encounter any roadblocks or flaws. Super nice work 👍 :)

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Built it locally - served it - checked showcase: Site was there and everything still works

Related PRs

--

@facebook-github-bot
Copy link
Contributor

Hi @JohnnyCrazy!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 5faffd1

https://deploy-preview-3307--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 19, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Aug 19, 2020
@slorber
Copy link
Collaborator

slorber commented Aug 19, 2020

thanks for the feedback :) will share it with the team

@slorber slorber merged commit c97dd65 into facebook:master Aug 19, 2020
@JohnnyCrazy JohnnyCrazy deleted the showcase-spotifyapi-net branch August 19, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants