Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Update Deploy to Vercel guide #3344

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

samcx
Copy link
Contributor

@samcx samcx commented Aug 27, 2020

Motivation

Hello from the Vercel team!

Just submitting an update to the Deploy to Vercel docs.

Have you read the Contributing Guidelines on pull requests?

Will simple Doc fixes require signing a CLA?

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@samcx samcx requested a review from yangshun as a code owner August 27, 2020 09:00
@facebook-github-bot
Copy link
Contributor

Hi @samsisle!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit f3d21e6

https://deploy-preview-3344--docusaurus-2.netlify.app

@slorber
Copy link
Collaborator

slorber commented Aug 27, 2020

Thanks, LGTM.

Not sure about the CLA, will give you an answer soon, but I think it is required.

@slorber
Copy link
Collaborator

slorber commented Aug 27, 2020

Yes the CLA is required.

Is it a problem for you?

@samcx
Copy link
Contributor Author

samcx commented Sep 1, 2020

@slorber I have signed the CLA under my personal GitHub account!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 1, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber
Copy link
Collaborator

slorber commented Sep 1, 2020

thanks :)

@slorber slorber merged commit 2a3fe86 into facebook:master Sep 1, 2020
@slorber slorber changed the title Update Deploy to Vercel guide docs(v2): Update Deploy to Vercel guide Sep 1, 2020
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Sep 1, 2020
slorber pushed a commit that referenced this pull request Sep 1, 2020
slorber added a commit that referenced this pull request Sep 1, 2020
)

* deprecated nextVersionLabel option

* useActivePlugin failfast option

* remove deprecated option nextVersionLabel

* routeBasePath: '' should be forbidden

* routeBasePath: '' should be forbidden

* Docs: do not show version badge if there is only 1 version: #3362

* allow sidebars file to not exist: fallback to empty sidebars
https://githu.com/facebook/docusaurus/issues/3366

* Ability to use classic theme/preset while not using docs/pages without trouble.
#3360

* fix netlify redirects

* do not throw if useDocs do not load?

* netlify deploy typo

* try to fix useDocs

* docs(v2): update Deploy to Vercel guide (#3344)

* filter annoying useDocs conditional require warning

* netlify deploy preview homepage

* typo

* try to trigger again CLA bot

Co-authored-by: Sam Ko <sam@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants