Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add DevContainer config for GitHub codespaces #4003

Merged
merged 2 commits into from
Jan 11, 2021
Merged

chore: add DevContainer config for GitHub codespaces #4003

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bb81d2
devops: Docusaurus Dev Container
kumaraditya303 Jan 6, 2021
9d2b5af
formatted devcontainer.json
slorber Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"name": "Docusaurus Dev Container",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why tabs?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just reformatted it

"image": "mcr.microsoft.com/vscode/devcontainers/typescript-node:0-10-buster",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did you choose the image here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need something on node LTS 14 instead of node 10

Copy link
Contributor Author

@kumaraditya303 kumaraditya303 Jan 6, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slorber Because the GitHub workflow are using nodejs 10 so I chose that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image I chose is one of the official GitHub codespaces images for nodejs with typescript support

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may move/require node 14 LTS soon so it's better to use node 14 directly for this feature

"settings": {
"terminal.integrated.shell.linux": "/bin/bash"
},
"extensions": [
"dbaeumer.vscode-eslint"
],
"forwardPorts": [
3000
],
"postCreateCommand": "yarn install",
}