Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change default actions timeout from 6h to 30m #4508

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Mar 24, 2021

Motivation

while working on #4404 i noticed that default timeout for github actions is set to 6h, in case of issues in webpack like here: https://github.com/facebook/docusaurus/runs/2181853194?check_suite_focus=true we can run into cases when job is never going to be finished.

default value is set to 360min (6h) and this change reduces it to 30min (no job for now is executed for longer than 12min on linux and 20min on windows)

ref: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes

Have you read the Contributing Guidelines on pull requests?

yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 24, 2021
@netlify
Copy link

netlify bot commented Mar 24, 2021

@netlify
Copy link

netlify bot commented Mar 24, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 2dd1840

https://deploy-preview-4508--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 79
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4508--docusaurus-2.netlify.app/

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 24, 2021
@slorber
Copy link
Collaborator

slorber commented Mar 24, 2021

thanks! make sense

@slorber slorber merged commit 839d9d7 into facebook:master Mar 24, 2021
@armano2 armano2 deleted the fix/workflows-timeout branch March 24, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants