fix(v2): examples should use Node 14 by default on CodeSandbox + regen with alpha72 #4574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
changed the title
|
[V1] Built with commit 95a9c31 |
|
[V2] Built with commit 95a9c31 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4574--docusaurus-2.netlify.app/ |
|
Size Change: 0 B Total Size: 576 kB ℹ️ View Unchanged
|
slorber
added a commit
that referenced
this pull request
Jul 22, 2021
…n with alpha72 (#4574) * codesandbox: use node 14 by default * Regenerate examples * Add example json files to prettierrignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Latest release requires Node 12 so CodeSandbox fails as it defaults to Node 10.
This set CodeSandbox to use Node 14 instead of Node 10
Also regen Codesandbox templates to use alpha72 instead of alpha71
Note: codesandbox doc is not very clear regarding which "node" or "container.node" we should use, cf codesandbox/codesandbox-client#1469 (comment)