Add missing i18n support in side nav breadcrumb #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelMarcey
approved these changes
Mar 4, 2018
|
You're welcome, thank you for having created and made possible to contribute to this great project 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I have noticed another (as in yesterday's PR #477) place where internationalization support seemed to be missing and submit this PR to hopefully help fixing gaps.
Motivation
When in a configuration where screen width is limited (e.g. small smartphone), a breadcrumb appears to help the user know where s·he is.
The breadcrumb simply was not taking selected language into account—in the case where localization was enabled and an additional language added.
This PR is here to localize the breadcrumb label, leveraging a local existing function for this purpose.
Have you read the Contributing Guidelines on pull requests?
Yes; the file went through prettier, which should conform to expected format and please the CI checker.
Manual tests were done.
Test Plan
Have a project with localization enabled, additional language supported and a content leading to multiple sections in the side nav bar
Reduce the size of the browser to the minimum to simulate a small device with limited width: the side navigation bar should appear, with the breadcrumb
Change language (by selecting it through the upper-right drop down menu) and navigate using the breadcrumb: all breadcrumb labels should take the selected language into account
Related PRs
PR #477 is in the same vein.