Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v2): allow any type of NavbarItem to be passed in dropdown #5072

Merged
merged 43 commits into from
Jul 14, 2021
Merged

feat(v2): allow any type of NavbarItem to be passed in dropdown #5072

merged 43 commits into from
Jul 14, 2021

Commits on Jun 26, 2021

  1. Initial work 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    ec200db View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2021

  1. More elegant eslint-disable 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    61081b8 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Fix typing 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    0643643 View commit details
    Browse the repository at this point in the history

  2. Allow doc links in dropdown 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    71b486f View commit details
    Browse the repository at this point in the history

  3. Allow more dropdowns to use linklike items 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    ddd4ae6 View commit details
    Browse the repository at this point in the history

  4. Finalize 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    adc47b1 View commit details
    Browse the repository at this point in the history

  5. Dogfood 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    9c69f97 View commit details
    Browse the repository at this point in the history

  6. Disallow nested dropdowns 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    8fae628 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. Better typing 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    79c7e92 View commit details
    Browse the repository at this point in the history

  2. Complete type fix 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    80815f9 View commit details
    Browse the repository at this point in the history

  3. Use flatmap 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    7e7de27 View commit details
    Browse the repository at this point in the history

  4. Patch 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    10acb67 View commit details
    Browse the repository at this point in the history

  5. Test 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    33cda97 View commit details
    Browse the repository at this point in the history

  6. Try fix 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    1d62f1d View commit details
    Browse the repository at this point in the history

  7. Style change 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    48fd04a View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. Revert (to test) 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    068dd3f View commit details
    Browse the repository at this point in the history

  2. Hmmm 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    a133ec2 View commit details
    Browse the repository at this point in the history

  3. I know what's wrong 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    f3901e6 View commit details
    Browse the repository at this point in the history

  4. Does this work? 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    24b162e View commit details
    Browse the repository at this point in the history

  5. Nope 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    2131e00 View commit details
    Browse the repository at this point in the history

  6. Wrong class name 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    70ca5d0 View commit details
    Browse the repository at this point in the history

  7. Pass prop to render dropdown item differently 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    a779adb View commit details
    Browse the repository at this point in the history

  8. This looks better 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    8c07257 View commit details
    Browse the repository at this point in the history

  9. Tests passed 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    fdf58d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2021

  1. Separate dropdown from default 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    c85fca9 View commit details
    Browse the repository at this point in the history

  2. Pourquois? 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    2153a14 View commit details
    Browse the repository at this point in the history

  3. Better prop typing 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    db74fbe View commit details
    Browse the repository at this point in the history

  4. Make code simpler 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    618df82 View commit details
    Browse the repository at this point in the history

  5. There's some extra className 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    27220a0 View commit details
    Browse the repository at this point in the history

  6. Test 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    3338b79 View commit details
    Browse the repository at this point in the history

  7. More test 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    2263083 View commit details
    Browse the repository at this point in the history

  8. A-ha! 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    4b9e171 View commit details
    Browse the repository at this point in the history

  9. Test again?

    @Josh-Cena
    Josh-Cena committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    dacf15f View commit details
    Browse the repository at this point in the history

  10. Add backward compatibility 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    559a7bf View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2021

  1. Merge branch 'master' into navbaritem 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    52d0aac View commit details
    Browse the repository at this point in the history

  2. Incorporate my type fix 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    c7ccd7c View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Resolve conflict 

    Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
    @Josh-Cena
    Josh-Cena committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    35b1b99 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into navbaritem

    @Josh-Cena
    Josh-Cena committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    3d12b30 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Merge branch 'master' into navbaritem 

    # Conflicts:
#	packages/docusaurus-theme-classic/src/theme/NavbarItem/DefaultNavbarItem.tsx
    @slorber
    slorber committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    e9895d6 View commit details
    Browse the repository at this point in the history

  2. minor refactor

    @slorber
    slorber committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    1075477 View commit details
    Browse the repository at this point in the history

  3. minor refactors

    @slorber
    slorber committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    07ce433 View commit details
    Browse the repository at this point in the history

  4. allow usage of ES2019 in browser code

    @slorber
    slorber committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    4ff53d7 View commit details
    Browse the repository at this point in the history

  5. revert NavLink rename

    @slorber
    slorber committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    c12f0ba View commit details
    Browse the repository at this point in the history