Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Crowdin mapping for pt-BR #5249

Merged
merged 1 commit into from
Jul 29, 2021
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 29, 2021

Motivation

For languages such as pt-BR we want to keep the full locale to distinguish from pt-PT so let's add some custom mapping to download translations at ì18n/pt-BR instead of i18n/pt (site config is already correct)

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jul 29, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 29, 2021
@netlify
Copy link

netlify bot commented Jul 29, 2021

✔️ [V2]

🔨 Explore the source changes: 7479ffa

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6102d6fe65f45d000848df48

😎 Browse the preview: https://deploy-preview-5249--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 86
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5249--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 905 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 71.3 kB
website/build/assets/css/styles.********.css 93.4 kB
website/build/assets/js/main.********.js 495 kB
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.5 kB
website/build/blog/index.html 26.4 kB
website/build/docs/index.html 40.6 kB
website/build/docs/installation/index.html 48.2 kB
website/build/index.html 27.4 kB
website/build/tests/docs/index.html 21.2 kB
website/build/tests/docs/standalone/index.html 19.1 kB

compressed-size-action

@rafaelbmateus
Copy link

LGTM!

@slorber
Copy link
Collaborator Author

slorber commented Jul 29, 2021

:)

@slorber slorber merged commit 36bea24 into master Jul 29, 2021
@slorber slorber deleted the slorber/fix-crowdin-pt-BR branch July 29, 2021 16:48
@slorber
Copy link
Collaborator Author

slorber commented Jul 29, 2021

@rafaelbmateus it's working now :)

https://docusaurus-i18n-staging.netlify.app/pt-BR/

Just had to fix a little translation braking the CI due to bad </code> <code> (sometimes Crowdin suggest weird translations with bad markup).

This seems good enough to go live on the official site. Do you plan to translate 100% so that we announce an "official pt-BR support" ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants