fix: fix canary release versions, use 0.0.0 scheme #5295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: maintenance
|
✔️ [V2] 🔨 Explore the source changes: 2a65dda 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/610bc01986259400073b48fb 😎 Browse the preview: https://deploy-preview-5295--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5295--docusaurus-2.netlify.app/ |
|
Size Change: -2 B (0%) Total Size: 787 kB ℹ️ View Unchanged
|
7 tasks
slorber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Another attempt to fix the canary release naming convention to avoid
^2.0.0-beta.0a668366c2picking up another version in lockfile after install.The commit hash should rather not be used as a semver pre-release identifier because commit hashes won't be ordered properly in semver order. Adding the commit hash after the
+is not used to determine precedence of the canary releases.Also we can't use
2.0.0prefix because non pre-release versions are picked up in priority over pre-release versions, so user might end-up with a stable release instead of a canary in the future. Switching to0.0.0makes sure that an user that really wants a canary will get a canary (assuming we'll never publish0.0.0). React/RN also use0.0.0https://semver.org/
Relevant spec paragraphs:
Useful for testing: https://semver.npmjs.com/