Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not ignore the layout header #587

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Do not ignore the layout header #587

merged 1 commit into from
Apr 20, 2018

Conversation

vjeux
Copy link
Contributor

@vjeux vjeux commented Apr 20, 2018 •
edited
Loading

#347 added support for warning for unknown fields but didn't take into account layout which was added by #128

@vjeux
Do not ignore the layout header
727b9f4 
#347 added support for warning for unknown fields but didn't take into account `layout` which was added by #128
@vjeux vjeux requested a review from JoelMarcey April 20, 2018 16:17
@yangshun yangshun merged commit c400636 into master Apr 20, 2018
@yangshun yangshun deleted the vjeux-patch-1 branch April 20, 2018 16:20
@yangshun
Copy link
Contributor

yangshun commented Apr 20, 2018 •
edited
Loading

Thanks @vjeux 😄

We'll need to document this field.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 20, 2018
@NikolayS NikolayS mentioned this pull request Jan 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelMarcey JoelMarcey Awaiting requested review from JoelMarcey

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vjeux @yangshun @facebook-github-bot