Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add Reddit Image Fetcher site to showcase #6856

Merged
merged 5 commits into from
Mar 8, 2022
Merged

docs: add Reddit Image Fetcher site to showcase #6856

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b7481ec
Add reddit-image-fetcher.png to showcase
arifszn Mar 6, 2022
898914d
Add Reddit Image Fetcher to users.tsx
arifszn Mar 6, 2022
1ce391e
Update reddit-image-fetcher.png with correct dimension
arifszn Mar 6, 2022
f0b1cbc
optimize image
Josh-Cena Mar 6, 2022
867b967
Set Reddit Image Fetcher's source as `null` and remove open source tag
arifszn Mar 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added website/src/data/showcase/reddit-image-fetcher.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions website/src/data/users.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1366,6 +1366,14 @@ const Users: User[] = [
source: 'https://github.com/redis-developer/redis-developer.github.io',
tags: ['opensource', 'product', 'design', 'favorite'],
},
{
title: 'Reddit Image Fetcher',
description: 'A JavaScript package for fetching reddit images, memes, wallpapers and more',
preview: require('./showcase/reddit-image-fetcher.png'),
website: 'https://arifszn.github.io/reddit-image-fetcher',
source: 'https://github.com/arifszn/reddit-image-fetcher',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to contain your website's source?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was following RactivePlayer's structure and I had the impression the source is the library's source.

Copy link
Collaborator

@Josh-Cena Josh-Cena Mar 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, indeed, that one probably slipped through the review. You do need to make the source point to your website's source. We care about your website, not your product ;)

Copy link
Contributor Author

@arifszn arifszn Mar 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Also, there are some more examples where the website source is not presented in the mentioned source URL e.g. Node SerialPort, Nocalhost. And other repos have the source as well as the library's source. So, you can guess why I misunderstood it as the library's source.

Currently, the website source is in another private repo. If it's the requirement then, I will move the website source to the library's subfolder. Which will take some time so you can close this PR for now. Or, source with null value is acceptable like Paubox, Prismatic, SmartCookieWeb?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do either: public your website's source, or indicate that your website is not open-source. No need to close the current PR though, we can always wait ;D

Thanks for pointing those sites out, I've noted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I will surely make the doc source open source soon and update the link. Could have made the repo public now but not super proud of the commit messages :p. For now, keeping the source as null.

tags: ['opensource'],
},
{
title: 'Refine',
description: 'A React-based framework for building data-intensive applications in no time!',
Expand Down