Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent page scrolling to top when clicking languages button on header #802

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Prevent page scrolling to top when clicking languages button on header #802

merged 1 commit into from
Jun 25, 2018

Conversation

ngyikp
Copy link
Contributor

@ngyikp ngyikp commented Jun 25, 2018

Motivation

Prevent the page scrolling to the top when you click the Languages button on the header

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

cd /path/to/docusaurus-repo
yarn
cd website
npm run start

Scroll down the page a bit, click the languages button on the header and ensure it doesn't scroll back to the top

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 25, 2018
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 249dd40

https://deploy-preview-802--docusaurus-preview.netlify.com

endiliey
endiliey approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ngyikp 😍

yangshun
yangshun approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow I never realized this. Good catch!

@yangshun yangshun merged commit 76870c6 into facebook:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun yangshun approved these changes

@endiliey endiliey endiliey approved these changes

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ngyikp @docusaurus-bot @yangshun @endiliey @facebook-github-bot