style: preserve sidebar height when toggling #8195
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
This PR makes the heights of the sidebar & the expand button fixed (100vh). This solves the layout shift.
Test Plan
2022-10-09.23-04-42.mp4
Go to a page where the sidebar height is greater than the main content height (an example is linked below). Try hiding/expanding the sidebar to make sure that there is no layout shift.
Test links
Deploy preview: https://deploy-preview-8195--docusaurus-2.netlify.app/tests/docs
Same page on prod: https://docusaurus.io/tests/docs
Related issues/PRs
Solves #4415