Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): docusaurus CLI should detect the correct yarn version when suggesting upgrades #9006

Merged
merged 6 commits into from
May 31, 2023
Merged

fix(core): docusaurus CLI should detect the correct yarn version when suggesting upgrades #9006

merged 6 commits into from
May 31, 2023

Commits on May 25, 2023

  1. fix(core): Correct yarn version detection 

    Correct yarn version detection by checking `yarnPath` value inside `.yarnrc.yml` file
Add js-yaml in package.json
    @0420syj
    0420syj committed May 25, 2023
    Configuration menu
    Copy the full SHA
    2a0e83e View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. Merge branch 'facebook:main' into correct-yarn-version-detection

    @0420syj
    0420syj committed May 31, 2023
    Configuration menu
    Copy the full SHA
    1914bed View commit details
    Browse the repository at this point in the history

  2. Change to use shelljs instead of js-yaml

    @0420syj
    0420syj committed May 31, 2023
    Configuration menu
    Copy the full SHA
    cd951d9 View commit details
    Browse the repository at this point in the history

  3. Change echo mode to silent

    @0420syj
    0420syj committed May 31, 2023
    Configuration menu
    Copy the full SHA
    027584f View commit details
    Browse the repository at this point in the history

  4. Check yarn.lock exist, before version checking

    @0420syj
    0420syj committed May 31, 2023
    Configuration menu
    Copy the full SHA
    c14a611 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary �optional chaining 

    �Nullish coalescing operator still provides the fallback value

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
    @0420syj @Josh-Cena
    0420syj and Josh-Cena committed May 31, 2023
    Configuration menu
    Copy the full SHA
    c4db321 View commit details
    Browse the repository at this point in the history