Update Sponsor image issue(#950) #951
Conversation
Removes links which are not required from Sponsors section
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Deploy preview for docusaurus-preview ready! Built with commit a74d456 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Thanks @ashwini0529! I understand the motivation but think the purpose of these links here is to act as placeholders so that if there are sponsors in future we don't have to update the README.
Can you show us screenshots of the broken image icon? From what I can tell, a 1 x 1 px image is loaded instead of a logo; those images are not broken.
|
Hey @yangshun, maybe for that we can look for some other solution? The current README will anyway have to be changed after 10 sponsors. Also, this has to load some amount of data. Maybe we could make it completely dynamic? Screenshot |
There was a problem hiding this comment.
The broken images seem to be a bug that has to be fixed but we should just prevent the bug from surfacing on our end.
Thanks for the find @ashwini0529!
Removes links which are not required from Sponsors section.
Fixes #950
Motivation
Sometimes the browser shows a broken image icon. Removing the links would fix this.