Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): enable port configuration via environment variable #9610

Merged
merged 4 commits into from Dec 7, 2023

Conversation

OzakIOne
Copy link
Collaborator

@OzakIOne OzakIOne commented Dec 4, 2023

Pre-flight checklist

Motivation

Fix #8681

Test Plan

Local test

Test links

Deploy preview: https://deploy-preview-9610--docusaurus-2.netlify.app/

Related issues/PRs

#8681

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 4, 2023
Copy link

netlify bot commented Dec 4, 2023

[V2]

Name Link
🔨 Latest commit 3c4918f
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65719e8952f9d7000802e582
😎 Deploy Preview https://deploy-preview-9610--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 4, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 66 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/installation 🟠 65 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/category/getting-started 🟠 74 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog 🟠 75 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 63 🟢 97 🟢 100 🟢 100 🟠 89 Report
/blog/tags/release 🟠 74 🟢 100 🟢 100 🟠 80 🟠 89 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟢 90 🟠 89 Report

@Josh-Cena
Copy link
Collaborator

Could you use "Fixes #8681" if your PR fixes that issue? This links the PR to the issue and auto-closes the latter.

@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Dec 5, 2023
packages/docusaurus/src/server/getHostPort.ts Outdated Show resolved Hide resolved
packages/docusaurus-utils/src/constants.ts Outdated Show resolved Hide resolved
@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Dec 7, 2023
@slorber slorber changed the title feat: Enable port configuration via environment variable feat(core): enable port configuration via environment variable Dec 7, 2023
@slorber slorber merged commit d3752d2 into facebook:main Dec 7, 2023
31 of 32 checks passed
@slorber slorber deleted the ozaki/env-port branch December 7, 2023 10:46
slorber added a commit that referenced this pull request Jan 5, 2024
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docusaurus doesn't respect the $PORT environment variable
4 participants