Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theme-common): code block MagicComments support for (Visual) Basic/Batch/Fortran/COBOL/ML #9671

Merged
merged 1 commit into from Dec 27, 2023
Merged

feat(theme-common): code block MagicComments support for (Visual) Basic/Batch/Fortran/COBOL/ML #9671

merged 1 commit into from Dec 27, 2023

Conversation

tats-u
Copy link
Contributor

@tats-u tats-u commented Dec 26, 2023 •
edited by slorber

Add support for more comment style for MagicComments:

  • (Visual) Basic (including .NET / for Applications)
  • CMD (Batch)
  • ML
    • SML
    • OCaml
    • F#
  • Fortran (90 or later & free format)
  • COBOL (free format)

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

https://deploy-preview-9671--docusaurus-2.netlify.app/tests/pages/code-block-tests#magic-comments-tests

Related issues/PRs

#8859
#8870

@tats-u tats-u requested a review from slorber as a code owner December 26, 2023 15:59
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 26, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 26, 2023 •
edited

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit f599cbb
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/658bfb3320ff820008f117e2
😎 Deploy Preview https://deploy-preview-9671--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 26, 2023 •
edited

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 56 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/installation 🟠 84 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/category/getting-started 🟠 76 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog 🟠 67 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 64 🟢 97 🟢 100 🟢 100 🟠 89 Report
/blog/tags/release 🟠 71 🟢 100 🟢 100 🟠 80 🟠 89 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟢 90 🟠 89 Report

@tats-u
Copy link
Contributor Author

tats-u commented Dec 26, 2023

How should I edit project-words.txt?

@slorber slorber added Argos Add this label to run UI visual regression tests. See argos.yml GH action. pr: new feature This PR adds a new API or behavior. labels Dec 27, 2023
@argos-ci Argos CI
Copy link

argos-ci bot commented Dec 27, 2023 •
edited

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 124 changes Jan 5, 2024, 6:56 PM

@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Dec 27, 2023
@slorber
Copy link
Collaborator

slorber commented Dec 27, 2023

thanks, lgtm 👍

@slorber slorber merged commit bd7d64f into facebook:main Dec 27, 2023
35 of 36 checks passed
@tats-u tats-u deleted the magic-comment-style branch December 27, 2023 23:31
slorber pushed a commit that referenced this pull request Jan 5, 2024
@tats-u @slorber
feat(theme-common): code block MagicComments support for (Visual) Bas…
539fd73 
…ic/Batch/Fortran/COBOL/ML (#9671)
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Jan 5, 2024
@tats-u tats-u mentioned this pull request Jan 11, 2024
Merged
3 tasks
@NikolayS NikolayS mentioned this pull request Apr 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorber slorber Awaiting requested review from slorber slorber is a code owner

Assignees
No one assigned
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tats-u @slorber @facebook-github-bot