Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mdx-loader): the table-of-contents should display toc/headings of imported MDX partials #9684

Merged
merged 35 commits into from Jan 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
c6b4b33
Headings from partials appear in ToC
anatolykopyl Dec 31, 2023
aa9caae
Fixed generated mdxjsEsm node value and added test page
anatolykopyl Jan 10, 2024
7f85855
Cleanup code and use astring instead of string concat
anatolykopyl Jan 12, 2024
be539db
Js now generates with import, not just the AST
anatolykopyl Jan 12, 2024
f386394
Update packages/docusaurus-mdx-loader/src/remark/toc/index.ts
anatolykopyl Jan 13, 2024
51f5d41
Added dogfooding and changed unit tests
anatolykopyl Jan 14, 2024
1fdd6af
Moved types into the file where they are used
anatolykopyl Jan 14, 2024
0b6cc68
restore former TOC snapshot format
slorber Jan 18, 2024
bfea370
TOC, revert usage to Markdown snapshots thanks to astring.generate(js…
slorber Jan 18, 2024
604febd
better unit tests
slorber Jan 18, 2024
758e39b
Add astring to devDependencies
slorber Jan 18, 2024
c7f5c14
Remove some unnecessary type casts
anatolykopyl Jan 18, 2024
3121dce
typo
slorber Jan 18, 2024
9fec883
typo
slorber Jan 18, 2024
baeb5bd
typo
slorber Jan 18, 2024
04636de
Minor changes to site preprocessor
slorber Jan 18, 2024
1e00363
better dogfooding case
slorber Jan 18, 2024
5d68e76
use MdxjsEsm type guard
slorber Jan 18, 2024
084f029
more refactors and function extractions
slorber Jan 18, 2024
2c0df85
more refactors
slorber Jan 18, 2024
763d208
more refactors + remove useless babel parser dependency
slorber Jan 18, 2024
418d95e
refactor handling of toc export node
slorber Jan 19, 2024
9e4f8aa
refactor handling of toc export node
slorber Jan 19, 2024
25c6a70
update yarn lock
slorber Jan 19, 2024
925661d
refactor implementation, solve edge case where partial import is done…
slorber Jan 19, 2024
9d3c544
add missing typeguard
slorber Jan 19, 2024
65592a6
minor naming refactors
slorber Jan 19, 2024
0348aa4
minor refactoring
slorber Jan 19, 2024
d070950
refactor TOC snapshots to use JS instead of MDX
slorber Jan 19, 2024
728d705
never override user-provided toc export
slorber Jan 19, 2024
86f7275
add export toc at the end instead of after last import
slorber Jan 19, 2024
f193b12
minor utils refactor
slorber Jan 19, 2024
239550b
rename tocSlice.name to tocSlide.importName
slorber Jan 19, 2024
9b258e7
remove useless toc explicit exports
slorber Jan 19, 2024
3d43631
remove useless toc explicit exports on website
slorber Jan 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/docusaurus-mdx-loader/package.json
Expand Up @@ -18,8 +18,6 @@
},
"license": "MIT",
"dependencies": {
"@babel/parser": "^7.22.7",
"@babel/traverse": "^7.22.8",
"@docusaurus/logger": "3.0.0",
"@docusaurus/utils": "3.0.0",
"@docusaurus/utils-validation": "3.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/docusaurus-mdx-loader/src/index.ts
Expand Up @@ -7,7 +7,7 @@

import {mdxLoader} from './loader';

import type {TOCItem as TOCItemImported} from './remark/toc';
import type {TOCItem as TOCItemImported} from './remark/toc/types';

export default mdxLoader;

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.