Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for client to include there own remarkable config #974

Merged
merged 8 commits into from
Sep 20, 2018
Merged

Added option for client to include there own remarkable config #974

merged 8 commits into from
Sep 20, 2018

Conversation

muuvmuuv
Copy link
Contributor

See: #972

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit f736939

https://deploy-preview-974--docusaurus-preview.netlify.com

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Sep 19, 2018

Deploy preview for docusaurus-preview ready!

Built with commit be09ee2

https://deploy-preview-974--docusaurus-preview.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 19, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

v1/lib/core/renderMarkdown.js Outdated Show resolved Hide resolved
@endiliey
Copy link
Contributor

@muuvmuuv please run prettier 😄

@muuvmuuv
Copy link
Contributor Author

@endiliey Oops sorry. I use Unibeautify to auto format my code. Forgot some projects do not have this ^^

Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shipit

@endiliey
Copy link
Contributor

Note that v2 way of dealing with Markdown will be different and won't be done via siteConfig.

@endiliey endiliey merged commit 8568a96 into facebook:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants