New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade babel 7 #995
Upgrade babel 7 #995
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will let @endiliey take a second look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting and tests are failing, could you have a second look @fiennyangeln
Use custom transform for jest to handle docs test since there is path change in there
166f22c
to
676e0d6
Compare
@yangshun I just discover it happen because I had a build in the website directory previously.. Thats why the test seems fine it my computer. Will investigate tomorrow |
Deploy preview for docusaurus-preview ready! Built with commit 978460f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just slight nits. We might need to move v2 to Babel 7 as well. Wanna send a PR?
v1/lib/__tests__/build-files.test.js
Outdated
@@ -28,7 +28,7 @@ let outputAssetsFiles = []; | |||
|
|||
function generateSite() { | |||
shell.cd('website'); | |||
shell.exec('yarn build', {silent: true}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intended. See #896
f47af8d
to
5c94da5
Compare
- add babel/types to expose method used in translate-plugin
5c94da5
to
978460f
Compare
@endiliey ok! let's do it in a different PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Use custom transform for jest to handle docs test since there is
path change in there
Motivation
#984
(Write your motivation here.)
Have you read the Contributing Guidelines on pull requests?
Yes
(Write your answer here.)
Test Plan
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)