Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docs,blog): last update timestamp should be in milliseconds instead of seconds #9963

Merged
merged 1 commit into from Mar 19, 2024

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Mar 18, 2024

Motivation

The last updated at timestamp read should be in milliseconds instead of seconds

Dealing with milliseconds is more convenient in JavaScript, and we shouldn't need to constantly convert it.

The only reason it was in second is because historically reading from git gives us a value in seconds, so let's convert it to ms at the root just after reading it from Git. This simplifies all the code down the line.

Test Plan

Unit tests + preview

@slorber slorber added pr: maintenance This PR does not produce any behavior differences to end users when upgrading. to backport This PR is planned to be backported to a stable version of Docusaurus Argos Add this label to run UI visual regression tests. See argos.yml GH action. labels Mar 18, 2024
@slorber slorber requested a review from Josh-Cena as a code owner March 18, 2024 19:02
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 18, 2024
Copy link

netlify bot commented Mar 18, 2024

[V2]

Name Link
🔨 Latest commit 6d41669
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65f88fba8d50bc000899a546
😎 Deploy Preview https://deploy-preview-9963--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 67 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 69 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 69 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 63 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 69 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report

Copy link

argos-ci bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Mar 18, 2024, 7:10 PM

Copy link

Size Change: 0 B

Total Size: 992 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 75.4 kB
website/build/assets/css/styles.********.css 114 kB
website/build/assets/js/main.********.js 765 kB
website/build/index.html 37.9 kB

compressed-size-action

@slorber slorber merged commit 465cf4d into main Mar 19, 2024
32 of 33 checks passed
@slorber slorber deleted the slorber/ms-timestamps branch March 19, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading. to backport This PR is planned to be backported to a stable version of Docusaurus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants