Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix codesandbox default privacy #9993

Merged
merged 2 commits into from Mar 29, 2024
Merged

chore: fix codesandbox default privacy #9993

merged 2 commits into from Mar 29, 2024

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Mar 28, 2024

Motivation

CodeSandbox repros we receive lately are private by default, which is annoying:

image

Apparently, new query string options have been implemented to prevent this, so let's figure what is the best for our use case.

https://twitter.com/CompuIves/status/1773028692752539825

CleanShot 2024-03-28 at 10 41 25

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 28, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 28, 2024
Copy link

netlify bot commented Mar 28, 2024

[V2]

Name Link
🔨 Latest commit 8308674
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6606f9fa3015890008fa06f7
😎 Deploy Preview https://deploy-preview-9993--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 28, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 42 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 56 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 68 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 61 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 68 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report

@slorber slorber added pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. and removed pr: maintenance This PR does not produce any behavior differences to end users when upgrading. labels Mar 29, 2024
@slorber slorber marked this pull request as ready for review March 29, 2024 17:27
@slorber slorber requested a review from Josh-Cena as a code owner March 29, 2024 17:27
@slorber
Copy link
Collaborator Author

slorber commented Mar 29, 2024

Note to self: from this twitter conversation I understand we can use the new ?fork=true&privacy=public query string.

Using fork=true is not an ideal general UX to me because users get presented with a modal immediately even before seeing Docusaurus running in a sandbox, so let's only use privacy=public alone

@slorber slorber merged commit 70415a4 into main Mar 29, 2024
10 checks passed
@slorber slorber deleted the slorber/public-sandbox branch March 29, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants