This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Add check for selection type of None #1192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just tested this locally and it works as expected |
mahlero
added a commit
to kumi-health/draft-js
that referenced
this pull request
May 12, 2017
|
Thanks for the fix, @dirkholsopple! Hope this gets merged in soon. |
|
+1 I would also like to see this merged in. |
|
Ya it'd be great to get this fixed! |
|
Please please please merge this |
|
@dirkholsopple Hi. Can you resolve the conflict with master? I'm very eager to get this PR merged in 😁 |
|
Closing in favor of #1190. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1188 which occurs when attempting to extend a Selection with type 'None'