Fixes incorrect docs, see #1497 #1837
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
@facebook-github-bot - I've now signed the CLA |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thanks for the shoutout @mattgreenfield! Also thanks for fixing it |
There was a problem hiding this comment.
niveditc is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: **Summary** Updates the docs to fix facebookarchive#1497. The current suggested method results in an `Element type is invalid:` error. I can confirm that using the component itself rather than its name as a string works as expected. Credit goes to albertlockett Pull Request resolved: facebookarchive#1837 Differential Revision: D9734736 fbshipit-source-id: 91aee43c504a3d5eda1bc74548f806faae4bc35d
Summary: **Summary** Updates the docs to fix #1497. The current suggested method results in an `Element type is invalid:` error. I can confirm that using the component itself rather than its name as a string works as expected. Credit goes to albertlockett Pull Request resolved: facebookarchive/draft-js#1837 Differential Revision: D9734736 fbshipit-source-id: 91aee43c504a3d5eda1bc74548f806faae4bc35d
Summary
Updates the docs to fix #1497. The current suggested method results in an
Element type is invalid:error.I can confirm that using the component itself rather than its name as a string works as expected.
Credit goes to @albertlockett