[Docs] Rename DraftEditorBlock to EditorBlock #2002
Conversation
The `DraftEditorBlock` component is exposed to the public API as `EditorBlock`. https://github.com/facebook/draft-js/blob/b4183b1519edcd075325adae0cb208551dc80f50/src/Draft.js#L45
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Good catch @umanghome, thanks for contributing a fix! 💯 |
There was a problem hiding this comment.
@claudiopro is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@claudiopro merged this pull request in 8514b57. |
Summary: **Summary** The `DraftEditorBlock` component is exposed to the public API as `EditorBlock`, while the [documentation](https://draftjs.org/docs/advanced-topics-block-components) still mentions `DraftEditorBlock`. https://github.com/facebook/draft-js/blob/b4183b1519edcd075325adae0cb208551dc80f50/src/Draft.js#L45 Pull Request resolved: facebookarchive#2002 Differential Revision: D15239547 Pulled By: claudiopro fbshipit-source-id: 43556827d1bc571e98b528562c88038f195534c7
Summary: **Summary** The `DraftEditorBlock` component is exposed to the public API as `EditorBlock`, while the [documentation](https://draftjs.org/docs/advanced-topics-block-components) still mentions `DraftEditorBlock`. https://github.com/facebook/draft-js/blob/b4183b1519edcd075325adae0cb208551dc80f50/src/Draft.js#L45 Pull Request resolved: facebookarchive#2002 Differential Revision: D15239547 Pulled By: claudiopro fbshipit-source-id: 43556827d1bc571e98b528562c88038f195534c7
Summary: **Summary** The `DraftEditorBlock` component is exposed to the public API as `EditorBlock`, while the [documentation](https://draftjs.org/docs/advanced-topics-block-components) still mentions `DraftEditorBlock`. https://github.com/facebook/draft-js/blob/b4183b1519edcd075325adae0cb208551dc80f50/src/Draft.js#L45 Pull Request resolved: facebookarchive/draft-js#2002 Differential Revision: D15239547 Pulled By: claudiopro fbshipit-source-id: 43556827d1bc571e98b528562c88038f195534c7
Summary
The
DraftEditorBlockcomponent is exposed to the public API asEditorBlock, while the documentation still mentionsDraftEditorBlock.https://github.com/facebook/draft-js/blob/b4183b1519edcd075325adae0cb208551dc80f50/src/Draft.js#L45