Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Update webpack deps #2310

Closed
wants to merge 1 commit into from
Closed

Update webpack deps #2310

wants to merge 1 commit into from

Conversation

mrkev
Copy link
Contributor

@mrkev mrkev commented Jan 22, 2020

Summary

This diff update build-related deps. We were creating more than one instance of webpack-stream, which is an error on the latest one, so I fix that too.

Test Plan

build && playground example

@@ -71,7 +71,12 @@ var COPYRIGHT_HEADER = `/**
*/
`;

var wpack = null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can we rename this wpStream? I think it would be easier to reason about

@claudiopro
Copy link
Contributor

Thanks for taking a look at this issue @mrkev ! Please take a look at my comment inline, not blocking on it though.

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@claudiopro claudiopro self-assigned this Jan 28, 2020
@claudiopro claudiopro added the build Issues related to the build label Jan 28, 2020
@mrkev
Copy link
Contributor Author

mrkev commented Jan 28, 2020

Sound good! I'll apply the changes internally through Phabricator and land it right away to keep things going.

@facebook-github-bot
Copy link

@mrkev merged this pull request in 0131e1d.

mmissey pushed a commit to mmissey/draft-js that referenced this pull request Mar 24, 2020
Summary:
**Summary**

This diff update build-related deps. We were creating more than one instance of `webpack-stream`, which is an error on the latest one, so I fix that too.

**Test Plan**

build && playground example
Pull Request resolved: facebookarchive#2310

Differential Revision: D19598315

Pulled By: mrkev

fbshipit-source-id: 5430f96576cadbd4f16b5a597dc77b9cc026d002
vilemj-Viclick pushed a commit to kontent-ai/draft-js that referenced this pull request Jul 16, 2020
Summary:
**Summary**

This diff update build-related deps. We were creating more than one instance of `webpack-stream`, which is an error on the latest one, so I fix that too.

**Test Plan**

build && playground example
Pull Request resolved: facebookarchive#2310

Differential Revision: D19598315

Pulled By: mrkev

fbshipit-source-id: 5430f96576cadbd4f16b5a597dc77b9cc026d002
alicayan008 pushed a commit to alicayan008/draft-js that referenced this pull request Jul 4, 2023
Summary:
**Summary**

This diff update build-related deps. We were creating more than one instance of `webpack-stream`, which is an error on the latest one, so I fix that too.

**Test Plan**

build && playground example
Pull Request resolved: facebookarchive/draft-js#2310

Differential Revision: D19598315

Pulled By: mrkev

fbshipit-source-id: 5430f96576cadbd4f16b5a597dc77b9cc026d002
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build Issues related to the build CLA Signed Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants