-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: Logging was turned on unconditionally before, which led to apps leaking sensitive data. This change puts the logging api behind an explicit gate that developers have to turn on. It's unfortunate that this isn't automatic - ideally this would automatically turn on for non-release signed bits. I couldn't find such a check in Android framework. If android experts have better ways of tackling this, i'm all ears. But bear in mind this is a security fix and needs to go out asap. Test Plan: Launched in default mode and verified no logging in emulator. Turned on log gate and verified logging. Reviewers: mmarucheck, lshepard, yariv, raghuc1 Reviewed By: mmarucheck CC: gregschechte, jacl Differential Revision: https://phabricator.fb.com/D411377 Task ID: 933141
- Loading branch information
Showing
3 changed files
with
32 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters