Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

RelatedArticles title should not render in footer #77

Closed
JohannesBeranek opened this issue Apr 24, 2016 · 1 comment
Closed

RelatedArticles title should not render in footer #77

JohannesBeranek opened this issue Apr 24, 2016 · 1 comment
Assignees
@demoive @everton-rosario
Labels
bug fixready needs review
Milestone
v1.5.4

Comments

@JohannesBeranek
Copy link

JohannesBeranek commented Apr 24, 2016 •
edited

Facebook UI is reporting title attribute as not supported when being used on an related articles element in the footer (which is in line with the FBIA specs). If possible though, RelatedArticles element shouldn't render title attribute when in footer.
@JohannesBeranek JohannesBeranek changed the title Related articles title not supported Related articles title not supported by FB Apr 24, 2016
@JohannesBeranek JohannesBeranek changed the title Related articles title not supported by FB Related articles title should not display in footer Apr 25, 2016
@JohannesBeranek JohannesBeranek changed the title Related articles title should not display in footer RelatedArticles title should not render in footer Apr 25, 2016
@simonengelhardt
Copy link
Contributor

@JohannesBeranek Good catch. Thanks for reporting 👍

everton-rosario added a commit that referenced this issue Dec 1, 2016
@everton-rosario
Fixes #77
5ba84c0 
There was an issue into the files FooterRelatedArticlesRule and RelatedArticlesRule that were requiring the title to be present in order to get the items inserted into the Related section.
Relates https://github.com/Automattic/facebook-instant-articles-wp/issues/550
@everton-rosario everton-rosario mentioned this issue Dec 1, 2016
Merged
2 tasks
@everton-rosario everton-rosario added this to the v1.5.4 milestone Dec 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@demoive demoive

@everton-rosario everton-rosario

Labels
bug fixready needs review
Projects
None yet
Milestone
v1.5.4
Development

No branches or pull requests
4 participants
@simonengelhardt @demoive @everton-rosario @JohannesBeranek