This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Issue 77 - Missing Footer title attribute #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue into the files FooterRelatedArticlesRule and RelatedArticlesRule that were requiring the title to be present in order to get the items inserted into the Related section. Relates https://github.com/Automattic/facebook-instant-articles-wp/issues/550
Also adds a InstantArticle::CURRENT_VERSION to the testIsRTLEnabled in order to not break tests with a new release.
demoive
reviewed
Dec 1, 2016
There was a problem hiding this comment.
@everton-rosario I don't think we intended for all the special characters to be changed in the 6e32c13#diff-d964c798e7db5ec394317b70830bcea2 file. Perhaps we needed to open this file with something other than UTF encoding when we edited it?
demoive
reviewed
Dec 1, 2016
| @@ -157,6 +157,42 @@ | |||
| "selector" : "*" | |||
| } | |||
| } | |||
| } | |||
| }, | |||
| @@ -157,6 +157,49 @@ | |||
| "selector" : "*" | |||
| } | |||
| } | |||
| } | |||
| }, | |||
|
@demoive Fixed the charsed encoding. Nice catch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes #77
Fixes https://github.com/Automattic/facebook-instant-articles-wp/issues/550