Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange event handling in FBDialog?? (FB Task #439550) #74

Closed
sfes opened this issue Oct 8, 2010 · 10 comments
Closed

Strange event handling in FBDialog?? (FB Task #439550) #74

sfes opened this issue Oct 8, 2010 · 10 comments

Comments

@sfes
Copy link

sfes commented Oct 8, 2010

When tapping 'Skip' button in FBDialog a delegate receives dialogDidComplete instead of dialogDidNotComplete. If this is not a bug please explain how to process a tap on 'Skip' button.

@cbarrett
Copy link

I'm seeing this as well. I added an NSLog to log the URL received by FBDialog's webView:shouldStartLoadWithRequest:navigationType:

For publish.stream, when I hit "Publish" I see:

url: https://www.facebook.com/connect/uiserver.php
url: fbconnect://success/?post_id=100000491842166_154457487927082

but when I hit Skip I see:

url: https://www.facebook.com/connect/uiserver.php
url: fbconnect://success

Looks like it's ignoring the cancel_url parameter.

@lionfly
Copy link

lionfly commented Nov 8, 2010

It is surprising that the API call the same method "dialogDidComplete" no matter whether "skip" or "publish" is pressed. I tried the following 3 methods to check, but none is called when "skip" is pressed:

  • (void)dialogDidNotCompleteWithUrl:(NSURL *)url { //never called
  • (void)dialogDidCancel:(NSURL *)url {//not called
  • (void)dialogDidNotComplete:(FBDialog *)dialog {//not called

Does Facebook has an official answer for this? What should we do to "expect" the solution?

@cedoucette
Copy link

I am also having this exact same problem.
There was also an issue in the old API.
I assumed it was fixed in this new API - obviously not yet...

https://github.com/facebook/facebook-iphone-sdk/issues/issue/13
http://forum.developers.facebook.net/viewtopic.php?pid=185090#p185090

@cancelself
Copy link

Opening an issue to look into this...

@cedoucette
Copy link

Whatever happened to this issue? Is it resolved? We are developing a new app with facebook integration. We'd like to know if the user pressed submit or cancel.

@TonySmule
Copy link

I just found this bug. It is quite disappointing to see that is still persists.

@taberrr
Copy link

taberrr commented Apr 15, 2011

Seeing the same thing, pretty annoying bug. :(

@taberrr
Copy link

taberrr commented Apr 16, 2011

Just figured out a workaround, in FBDialog.m, around line 400 (after NSURL* url = request.URL;) ... add the following:

if ([[url absoluteString] isEqualToString: @"fbconnect://success"] == YES) {
    [self dialogDidCancel:url];
    return NO;
}

Seems to do the trick for me.

@jverdi
Copy link

jverdi commented Nov 17, 2011

We ran into this with ShareKit as well:
ShareKit/ShareKit#83

Seems there are issues open in Facebook's bug tracker for this:
http://developers.facebook.com/bugs/137604089677897?browse=search_4ec3715ee70598199320073
https://developers.facebook.com/bugs/153320298096609?browse=search_4ec373f2be1aa0313896178

It's referenced here on GitHub in issues:
#11 (closed) - #11
#74 - #74
#209 - #209

Please make it a priority to get a fix for this into the master repo.

@jamesgpearce
Copy link

This issue was raised against a previous version of the Facebook SDK for iOS.

In 2012, the SDK had a significant rewrite and relaunch, and we are closing issues and pull requests that predate that v3.0 release.

If you are still experiencing this issue, please raise a new issue with repro steps in the supported SDK (currently v3.10). For more information, please see our iOS developer center at https://developers.facebook.com/docs/ios/

Many thanks for using the Facebook Platform, and your support of this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants